[
https://issues.apache.org/jira/browse/BEAM-3738?focusedWorklogId=83435&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-83435
]
ASF GitHub Bot logged work on BEAM-3738:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Mar/18 01:45
Start Date: 23/Mar/18 01:45
Worklog Time Spent: 10m
Work Description: udim commented on a change in pull request #4877:
[BEAM-3738] Enable py3 lint and cleanup tox.ini.
URL: https://github.com/apache/beam/pull/4877#discussion_r175908871
##########
File path: sdks/python/setup.py
##########
@@ -113,11 +113,8 @@ def get_version():
'futures>=3.1.1,<4.0.0',
]
-REQUIRED_SETUP_PACKAGES = [
- 'nose>=1.0',
Review comment:
@aaltay setup_requires= lists packages required to run setup.py. I couldn't
see why nose is required for that.
Specifying nose in the tests_require= keyword arg is sufficient.
@cclauss I would like to leave it alone in this PR, and I don't have any
objection to raising the required version.
Note that creating a new virtualenv installs (at least for me) a version of
pip that's newer than the system installed version (9.0.2 vs 9.0.1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 83435)
Time Spent: 9.5h (was: 9h 20m)
> Enable Py3 linting in Jenkins
> -----------------------------
>
> Key: BEAM-3738
> URL: https://issues.apache.org/jira/browse/BEAM-3738
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core, testing
> Reporter: holdenk
> Assignee: Ahmet Altay
> Priority: Major
> Time Spent: 9.5h
> Remaining Estimate: 0h
>
> After BEAM-3671 is finished enable linting.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
