[
https://issues.apache.org/jira/browse/BEAM-3848?focusedWorklogId=84394&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-84394
]
ASF GitHub Bot logged work on BEAM-3848:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Mar/18 15:26
Start Date: 26/Mar/18 15:26
Worklog Time Spent: 10m
Work Description: iemejia commented on a change in pull request #4905:
[BEAM-3848] Enables ability to retry Solr writes on error (SolrIO)
URL: https://github.com/apache/beam/pull/4905#discussion_r177097352
##########
File path:
sdks/java/io/solr/src/main/java/org/apache/beam/sdk/io/solr/SolrIO.java
##########
@@ -623,11 +683,36 @@ Write withMaxBatchSize(int batchSize) {
return builder().setMaxBatchSize(batchSize).build();
}
+ /**
+ * Provide configuration for enabling the retrying of a failed batch call
to Solr. A batch is
+ * considered as failed if the underlying {@link CloudSolrClient} surfaces
{@link
+ * org.apache.solr.client.solrj.impl.HttpSolrClient.RemoteSolrException},
{@link
+ * SolrServerException} or {@link IOException}. Users should consider that
retrying might
+ * compound the underlying problem which caused the initial failure. Users
should also be aware
+ * that once retrying is exhausted the error is surfaced to the runner
which <em>may</em> then
+ * opt to retry the current partition in entirety. Retrying uses an
exponential backoff
Review comment:
After '... entirety' you can add 'or abort if the max number of retries of
the runner is completed' (obvious but better explicit).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 84394)
Time Spent: 1h 40m (was: 1.5h)
> SolrIO: Improve retrying mechanism in client writes
> ---------------------------------------------------
>
> Key: BEAM-3848
> URL: https://issues.apache.org/jira/browse/BEAM-3848
> Project: Beam
> Issue Type: Improvement
> Components: io-java-solr
> Affects Versions: 2.2.0, 2.3.0
> Reporter: Tim Robertson
> Assignee: Tim Robertson
> Priority: Minor
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> A busy SOLR server is prone to return RemoteSOLRException on writing which
> currently fails a complete task (e.g. a partition of a spark RDD being
> written to SOLR).
> A good addition would be the ability to provide a retrying mechanism for the
> batch in flight, rather than failing fast, which will most likely trigger a
> much larger retry of more writes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
