[
https://issues.apache.org/jira/browse/BEAM-3848?focusedWorklogId=84392&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-84392
]
ASF GitHub Bot logged work on BEAM-3848:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Mar/18 15:26
Start Date: 26/Mar/18 15:26
Worklog Time Spent: 10m
Work Description: iemejia commented on a change in pull request #4905:
[BEAM-3848] Enables ability to retry Solr writes on error (SolrIO)
URL: https://github.com/apache/beam/pull/4905#discussion_r177098150
##########
File path:
sdks/java/io/solr/src/main/java/org/apache/beam/sdk/io/solr/SolrIO.java
##########
@@ -661,25 +746,51 @@ public void processElement(ProcessContext context)
throws Exception {
SolrInputDocument document = context.element();
batch.add(document);
if (batch.size() >= spec.getMaxBatchSize()) {
- flushBatch();
+ flushBatch(solrClient, batch);
Review comment:
I suppose the new solrClient parameter in this method is to be able to test
it, if this is the case I would prefer that we remove it from there and expose
it as a package private method in the WriteFn class with the
`@VisibleForTesting` annotation. Hope it does not make the mocking of the tests
too complicated, but it is just to let the internal state hidden.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 84392)
> SolrIO: Improve retrying mechanism in client writes
> ---------------------------------------------------
>
> Key: BEAM-3848
> URL: https://issues.apache.org/jira/browse/BEAM-3848
> Project: Beam
> Issue Type: Improvement
> Components: io-java-solr
> Affects Versions: 2.2.0, 2.3.0
> Reporter: Tim Robertson
> Assignee: Tim Robertson
> Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> A busy SOLR server is prone to return RemoteSOLRException on writing which
> currently fails a complete task (e.g. a partition of a spark RDD being
> written to SOLR).
> A good addition would be the ability to provide a retrying mechanism for the
> batch in flight, rather than failing fast, which will most likely trigger a
> much larger retry of more writes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
