[
https://issues.apache.org/jira/browse/BEAM-3738?focusedWorklogId=85017&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-85017
]
ASF GitHub Bot logged work on BEAM-3738:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/18 20:42
Start Date: 27/Mar/18 20:42
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #4798:
[BEAM-3738] Add more flake8 tests to run_pylint.sh
URL: https://github.com/apache/beam/pull/4798#discussion_r177565468
##########
File path: sdks/python/run_mini_py3lint.sh
##########
@@ -37,4 +37,5 @@ if test $# -gt 0; then
fi
echo "Running flake8 for module $MODULE:"
-flake8 $MODULE --count --select=E999 --show-source --statistics
+# TODO: Add F821 (undefined names) as soon as that test passes
Review comment:
It is fine to move that sentence to a JIRA, and add a todo referencing that
JIRA. People reading that TODO once it is merged would not easily be able to
find the PR and understand what is the todo for, and what needs to happen to
resolve it.
You can also reference the issues you have noticed with F821 as you
mentioned in your other comment in that same JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 85017)
Time Spent: 14.5h (was: 14h 20m)
> Enable Py3 linting in Jenkins
> -----------------------------
>
> Key: BEAM-3738
> URL: https://issues.apache.org/jira/browse/BEAM-3738
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core, testing
> Reporter: holdenk
> Assignee: Ahmet Altay
> Priority: Major
> Time Spent: 14.5h
> Remaining Estimate: 0h
>
> After BEAM-3671 is finished enable linting.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
