[
https://issues.apache.org/jira/browse/BEAM-3738?focusedWorklogId=85328&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-85328
]
ASF GitHub Bot logged work on BEAM-3738:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Mar/18 17:16
Start Date: 28/Mar/18 17:16
Worklog Time Spent: 10m
Work Description: asfgit closed pull request #4798: [BEAM-3738] Add more
flake8 tests to run_pylint.sh
URL: https://github.com/apache/beam/pull/4798
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/python/run_mini_py3lint.sh b/sdks/python/run_mini_py3lint.sh
index f5e9acd70b3..c4bd37fbb6c 100755
--- a/sdks/python/run_mini_py3lint.sh
+++ b/sdks/python/run_mini_py3lint.sh
@@ -37,4 +37,5 @@ if test $# -gt 0; then
fi
echo "Running flake8 for module $MODULE:"
-flake8 $MODULE --count --select=E999 --show-source --statistics
+# TODO: Add F821 (undefined names) as soon as that test passes
+flake8 $MODULE --count --select=E9,F822,F823 --show-source --statistics
diff --git a/sdks/python/run_pylint.sh b/sdks/python/run_pylint.sh
index e3f9a8e267f..93f68d40a73 100755
--- a/sdks/python/run_pylint.sh
+++ b/sdks/python/run_pylint.sh
@@ -63,7 +63,8 @@ pylint -j8 "$MODULE" --ignore-patterns="$FILES_TO_IGNORE"
echo "Running pycodestyle for module $MODULE:"
pycodestyle "$MODULE" --exclude="$FILES_TO_IGNORE"
echo "Running flake8 for module $MODULE:"
-flake8 $MODULE --count --select=E999 --show-source --statistics
+# TODO: Add F821 (undefined names) as soon as that test passes
+flake8 $MODULE --count --select=E9,F822,F823 --show-source --statistics
echo "Running isort for module $MODULE:"
# Skip files where isort is behaving weirdly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 85328)
Time Spent: 14h 50m (was: 14h 40m)
> Enable Py3 linting in Jenkins
> -----------------------------
>
> Key: BEAM-3738
> URL: https://issues.apache.org/jira/browse/BEAM-3738
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core, testing
> Reporter: holdenk
> Assignee: Ahmet Altay
> Priority: Major
> Time Spent: 14h 50m
> Remaining Estimate: 0h
>
> After BEAM-3671 is finished enable linting.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
