[
https://issues.apache.org/jira/browse/BEAM-3951?focusedWorklogId=85054&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-85054
]
ASF GitHub Bot logged work on BEAM-3951:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/18 22:37
Start Date: 27/Mar/18 22:37
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #4958:
[BEAM-3951] Migrate container instructions and builds to Gradle
URL: https://github.com/apache/beam/pull/4958#discussion_r177591703
##########
File path: build_rules.gradle
##########
@@ -489,6 +489,22 @@ ext.applyDockerNature = {
}
}
+def containerImageName(name) {
Review comment:
Add method comment.
Interesting that def works, before I was sticking everything onto ext. This
seems much cleaner. Consider swapping all usages of ext.fooBar = {} to def
fooBar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 85054)
Time Spent: 20m (was: 10m)
> Update SDK container images and instructions to use Gradle
> ----------------------------------------------------------
>
> Key: BEAM-3951
> URL: https://issues.apache.org/jira/browse/BEAM-3951
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Henning Rohde
> Assignee: Henning Rohde
> Priority: Major
> Labels: portability
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
