[
https://issues.apache.org/jira/browse/BEAM-3964?focusedWorklogId=86073&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-86073
]
ASF GitHub Bot logged work on BEAM-3964:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Mar/18 16:38
Start Date: 30/Mar/18 16:38
Worklog Time Spent: 10m
Work Description: tgroh closed pull request #4981: [BEAM-3964]
Temporarily reintroduce MetricName#name[space]
URL: https://github.com/apache/beam/pull/4981
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricName.java
b/sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricName.java
index 56d897a2863..7047e871f4b 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricName.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricName.java
@@ -37,9 +37,29 @@
/** The namespace associated with this metric. */
public abstract String getNamespace();
+ /**
+ * The namespace associated with this metric.
+ *
+ * @deprecated to be removed once Dataflow no longer requires this method.
+ */
+ @Deprecated
+ public String namespace() {
+ return getNamespace();
+ }
+
/** The name of this metric. */
public abstract String getName();
+ /**
+ * The name of this metric.
+ *
+ * @deprecated to be removed once Dataflow no longer requires this method.
+ */
+ @Deprecated
+ public String name() {
+ return getName();
+ }
+
public static MetricName named(String namespace, String name) {
checkArgument(!Strings.isNullOrEmpty(namespace), "Metric namespace must be
non-empty");
checkArgument(!Strings.isNullOrEmpty(name), "Metric name must be
non-empty");
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 86073)
Time Spent: 1h 10m (was: 1h)
> Java Github HEAD doesn't run on Dataflow
> ----------------------------------------
>
> Key: BEAM-3964
> URL: https://issues.apache.org/jira/browse/BEAM-3964
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Thomas Groh
> Assignee: Thomas Groh
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Rather: it runs, but cannot make progress, seemingly due to an Error with
> metric names:
>
> exception: "java.lang.NoSuchMethodError:
> org.apache.beam.sdk.metrics.MetricName.name()Ljava/lang/String; at
> com.google.cloud.dataflow.worker.MetricsToCounterUpdateConverter.structuredNameAndMetadata(MetricsToCounterUpdateConverter.java:99)
> at
> com.google.cloud.dataflow.worker.MetricsToCounterUpdateConverter.fromCounter(MetricsToCounterUpdateConverter.java:68)
> at
> com.google.cloud.dataflow.worker.BatchModeExecutionContext.lambda$null$1(BatchModeExecutionContext.java:463)
> at
> com.google.cloud.dataflow.worker.repackaged.com.google.common.collect.Iterators$7.transform(Iterators.java:750)
> at
> com.google.cloud.dataflow.worker.repackaged.com.google.common.collect.TransformedIterator.next(TransformedIterator.java:47)
> at
> com.google.cloud.dataflow.worker.repackaged.com.google.common.collect.MultitransformedIterator.next(MultitransformedIterator.java:66)
> at
> com.google.cloud.dataflow.worker.repackaged.com.google.common.collect.ImmutableCollection$Builder.addAll(ImmutableCollection.java:388)
> at
> com.google.cloud.dataflow.worker.repackaged.com.google.common.collect.ImmutableCollection$ArrayBasedBuilder.addAll(ImmutableCollection.java:472)
> at
> com.google.cloud.dataflow.worker.repackaged.com.google.common.collect.ImmutableList$Builder.addAll(ImmutableList.java:669)
> at
> com.google.cloud.dataflow.worker.WorkItemStatusClient.populateCounterUpdates(WorkItemStatusClient.java:256)
> at
> com.google.cloud.dataflow.worker.WorkItemStatusClient.createStatusUpdate(WorkItemStatusClient.java:240)
> at
> com.google.cloud.dataflow.worker.WorkItemStatusClient.reportError(WorkItemStatusClient.java:94)
> at
> com.google.cloud.dataflow.worker.BatchDataflowWorker.doWork(BatchDataflowWorker.java:358)
> at
> com.google.cloud.dataflow.worker.BatchDataflowWorker.getAndPerformWork(BatchDataflowWorker.java:284)
> at
> com.google.cloud.dataflow.worker.DataflowBatchWorkerHarness$WorkerThread.doWork(DataflowBatchWorkerHarness.java:134)
> at
> com.google.cloud.dataflow.worker.DataflowBatchWorkerHarness$WorkerThread.call(DataflowBatchWorkerHarness.java:114)
> at
> com.google.cloud.dataflow.worker.DataflowBatchWorkerHarness$WorkerThread.call(DataflowBatchWorkerHarness.java:101)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
>
> Probably requires an updated container version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
