[
https://issues.apache.org/jira/browse/BEAM-3964?focusedWorklogId=86626&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-86626
]
ASF GitHub Bot logged work on BEAM-3964:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/18 16:14
Start Date: 02/Apr/18 16:14
Worklog Time Spent: 10m
Work Description: tgroh closed pull request #4971: [BEAM-3964]
Temporarily Disable Dataflow Tests
URL: https://github.com/apache/beam/pull/4971
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Dataflow.groovy
b/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Dataflow.groovy
index 3230f9a5787..0b565cc199e 100644
---
a/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Dataflow.groovy
+++
b/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Dataflow.groovy
@@ -21,6 +21,9 @@ import common_job_properties
// This job runs the suite of ValidatesRunner tests against the Dataflow
// runner.
mavenJob('beam_PostCommit_Java_ValidatesRunner_Dataflow') {
+ // BEAM-3964: Metric method renaming breaks Dataflow
+ disabled()
+
description('Runs the ValidatesRunner suite on the Dataflow runner.')
previousNames('beam_PostCommit_Java_RunnableOnService_Dataflow')
diff --git a/.test-infra/jenkins/job_beam_PreCommit_Java_MavenInstall.groovy
b/.test-infra/jenkins/job_beam_PreCommit_Java_MavenInstall.groovy
index 38fef725e78..89bff694232 100644
--- a/.test-infra/jenkins/job_beam_PreCommit_Java_MavenInstall.groovy
+++ b/.test-infra/jenkins/job_beam_PreCommit_Java_MavenInstall.groovy
@@ -40,11 +40,19 @@ mavenJob('beam_PreCommit_Java_MavenInstall') {
// Sets that this is a PreCommit job.
common_job_properties.setPreCommit(delegate, 'mvn clean install -pl
sdks/java/core,runners/direct-java,sdks/java/fn-execution -am -amd', 'Run Java
PreCommit')
+ runner_profiles = [
+ 'direct-runner',
+ // BEAM-3964: Metric method renaming breaks Dataflow
+ // 'dataflow-runner',
+ 'spark-runner',
+ 'flink-runner',
+ 'apex-runner'
+ ].join(',')
// Maven goals for this job: The Java SDK, its dependencies, and things that
depend on it.
goals([
'--batch-mode',
'--errors',
- '--activate-profiles
release,jenkins-precommit,direct-runner,dataflow-runner,spark-runner,flink-runner,apex-runner',
+ '--activate-profiles release,jenkins-precommit,${runner_profiles}',
'--projects sdks/java/core,runners/direct-java,sdks/java/fn-execution',
'--also-make',
'--also-make-dependents',
diff --git a/runners/google-cloud-dataflow-java/build.gradle
b/runners/google-cloud-dataflow-java/build.gradle
index b75b97d9208..26d8af0dee3 100644
--- a/runners/google-cloud-dataflow-java/build.gradle
+++ b/runners/google-cloud-dataflow-java/build.gradle
@@ -37,6 +37,7 @@ processResources {
filter org.apache.tools.ant.filters.ReplaceTokens, tokens: [
'dataflow.legacy_environment_major_version' : '7',
'dataflow.fnapi_environment_major_version' : '1',
+ /* BEAM-3964: Metric method renaming breaks Dataflow. Reenable Dataflow
Tests once updated */
'dataflow.container_version' : 'beam-master-20180228'
]
}
diff --git a/runners/google-cloud-dataflow-java/pom.xml
b/runners/google-cloud-dataflow-java/pom.xml
index 8640fbc0315..a942997bf8e 100644
--- a/runners/google-cloud-dataflow-java/pom.xml
+++ b/runners/google-cloud-dataflow-java/pom.xml
@@ -33,6 +33,7 @@
<packaging>jar</packaging>
<properties>
+ <!-- BEAM-3964: Metric method renaming breaks Dataflow. Reenable Dataflow
Tests once updated -->
<dataflow.container_version>beam-master-20180228</dataflow.container_version>
<dataflow.fnapi_environment_major_version>1</dataflow.fnapi_environment_major_version>
<dataflow.legacy_environment_major_version>7</dataflow.legacy_environment_major_version>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 86626)
Time Spent: 1.5h (was: 1h 20m)
> Java Github HEAD doesn't run on Dataflow
> ----------------------------------------
>
> Key: BEAM-3964
> URL: https://issues.apache.org/jira/browse/BEAM-3964
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Thomas Groh
> Assignee: Thomas Groh
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Rather: it runs, but cannot make progress, seemingly due to an Error with
> metric names:
>
> exception: "java.lang.NoSuchMethodError:
> org.apache.beam.sdk.metrics.MetricName.name()Ljava/lang/String; at
> com.google.cloud.dataflow.worker.MetricsToCounterUpdateConverter.structuredNameAndMetadata(MetricsToCounterUpdateConverter.java:99)
> at
> com.google.cloud.dataflow.worker.MetricsToCounterUpdateConverter.fromCounter(MetricsToCounterUpdateConverter.java:68)
> at
> com.google.cloud.dataflow.worker.BatchModeExecutionContext.lambda$null$1(BatchModeExecutionContext.java:463)
> at
> com.google.cloud.dataflow.worker.repackaged.com.google.common.collect.Iterators$7.transform(Iterators.java:750)
> at
> com.google.cloud.dataflow.worker.repackaged.com.google.common.collect.TransformedIterator.next(TransformedIterator.java:47)
> at
> com.google.cloud.dataflow.worker.repackaged.com.google.common.collect.MultitransformedIterator.next(MultitransformedIterator.java:66)
> at
> com.google.cloud.dataflow.worker.repackaged.com.google.common.collect.ImmutableCollection$Builder.addAll(ImmutableCollection.java:388)
> at
> com.google.cloud.dataflow.worker.repackaged.com.google.common.collect.ImmutableCollection$ArrayBasedBuilder.addAll(ImmutableCollection.java:472)
> at
> com.google.cloud.dataflow.worker.repackaged.com.google.common.collect.ImmutableList$Builder.addAll(ImmutableList.java:669)
> at
> com.google.cloud.dataflow.worker.WorkItemStatusClient.populateCounterUpdates(WorkItemStatusClient.java:256)
> at
> com.google.cloud.dataflow.worker.WorkItemStatusClient.createStatusUpdate(WorkItemStatusClient.java:240)
> at
> com.google.cloud.dataflow.worker.WorkItemStatusClient.reportError(WorkItemStatusClient.java:94)
> at
> com.google.cloud.dataflow.worker.BatchDataflowWorker.doWork(BatchDataflowWorker.java:358)
> at
> com.google.cloud.dataflow.worker.BatchDataflowWorker.getAndPerformWork(BatchDataflowWorker.java:284)
> at
> com.google.cloud.dataflow.worker.DataflowBatchWorkerHarness$WorkerThread.doWork(DataflowBatchWorkerHarness.java:134)
> at
> com.google.cloud.dataflow.worker.DataflowBatchWorkerHarness$WorkerThread.call(DataflowBatchWorkerHarness.java:114)
> at
> com.google.cloud.dataflow.worker.DataflowBatchWorkerHarness$WorkerThread.call(DataflowBatchWorkerHarness.java:101)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
>
> Probably requires an updated container version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
