[
https://issues.apache.org/jira/browse/BEAM-3818?focusedWorklogId=86271&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-86271
]
ASF GitHub Bot logged work on BEAM-3818:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Mar/18 07:20
Start Date: 31/Mar/18 07:20
Worklog Time Spent: 10m
Work Description: mariapython commented on a change in pull request
#4949: [BEAM-3818] Add support for streaming side inputs in the DirectRunner
(part 2: unblock tasks as the _SideInputsContainer gets updated)
URL: https://github.com/apache/beam/pull/4949#discussion_r178425447
##########
File path: sdks/python/apache_beam/runners/direct/evaluation_context.py
##########
@@ -138,7 +180,9 @@ def _pvalue_to_value(self, view, values):
Raises:
ValueError: If values cannot be converted into the requested form.
"""
- return sideinputs.SideInputMap(type(view), view._view_options(), values)
+ return sideinputs.SideInputMap(type(side_input),
Review comment:
That method was existing code. I simply changed, for consistency, the name
of a variable that appears to be an _UnpickledSideInput in the uses I gave it
(and currently given by the project). But perhaps its designer intended a more
generic scope. I can't tell.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 86271)
Time Spent: 8h 50m (was: 8h 40m)
> Add support for the streaming side inputs in the Python DirectRunner
> --------------------------------------------------------------------
>
> Key: BEAM-3818
> URL: https://issues.apache.org/jira/browse/BEAM-3818
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: María GH
> Assignee: María GH
> Priority: Minor
> Fix For: 3.0.0
>
> Time Spent: 8h 50m
> Remaining Estimate: 0h
>
> The streaming DirectRunner should support streaming side input semantics.
> Currently, side inputs are only available for globally-windowed side input
> PCollections.
> Also, empty side inputs cause a pipeline stall.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
