[
https://issues.apache.org/jira/browse/BEAM-3818?focusedWorklogId=86692&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-86692
]
ASF GitHub Bot logged work on BEAM-3818:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/18 18:29
Start Date: 02/Apr/18 18:29
Worklog Time Spent: 10m
Work Description: mariapython commented on a change in pull request
#4949: [BEAM-3818] Add support for streaming side inputs in the DirectRunner
(part 2: unblock tasks as the _SideInputsContainer gets updated)
URL: https://github.com/apache/beam/pull/4949#discussion_r178610974
##########
File path: sdks/python/apache_beam/runners/direct/executor.py
##########
@@ -271,6 +272,14 @@ def __init__(self, transform_evaluator_registry,
evaluation_context,
self._transform_evaluator_registry = transform_evaluator_registry
self._evaluation_context = evaluation_context
self._input_bundle = input_bundle
+ # For non-empty bundles, store the window of the max EOW.
+ # TODO(mariagh): Move to class _Bundle's inner _StackedWindowedValues
+ # if input_bundle._elements:
Review comment:
Both parts are needed.
`# For non-empty bundles, store the window of the max EOW.` was part of the
initial PR.
`# TODO(mariagh): Move...` was added as a review request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 86692)
Time Spent: 10h 40m (was: 10.5h)
> Add support for the streaming side inputs in the Python DirectRunner
> --------------------------------------------------------------------
>
> Key: BEAM-3818
> URL: https://issues.apache.org/jira/browse/BEAM-3818
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: María GH
> Assignee: María GH
> Priority: Minor
> Fix For: 3.0.0
>
> Time Spent: 10h 40m
> Remaining Estimate: 0h
>
> The streaming DirectRunner should support streaming side input semantics.
> Currently, side inputs are only available for globally-windowed side input
> PCollections.
> Also, empty side inputs cause a pipeline stall.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
