[
https://issues.apache.org/jira/browse/BEAM-3942?focusedWorklogId=87552&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87552
]
ASF GitHub Bot logged work on BEAM-3942:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/18 14:09
Start Date: 04/Apr/18 14:09
Worklog Time Spent: 10m
Work Description: lgajowy commented on issue #5003: [BEAM-3942] Update
performance testing framework to use Gradle
URL: https://github.com/apache/beam/pull/5003#issuecomment-378612975
Thanks to @lukecwik suggestion, this PR got changed a little bit. The task
remained the same, but their placement is different. Now those are located in
the root's build_rules. Same as before, those are applied only to those
subprojects which need it.
All tasks reuse the JavaPerformanceTestConfiguration class to fetch and use
system properties.
One last important thing to notice is that `performanceTest` task is
designed to be run from the root project directory. I found it easier, because:
1. Placing the task in each subproject would require adding -p option in
order to run exactly one test. Running from root will invoke all
performanceTest tasks which is not what we want.
2. Running with -p option makes it harder to use relative paths. Because
Perfkit is now invoked in the subproject (eg. sdks/java/io/jdbc), we cannot
pass it paths starting from root project (eg. .test-infra). This also applies
to ./gradlew.
@lukecwik could you also take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 87552)
Time Spent: 1.5h (was: 1h 20m)
> Update performance testing framework to use Gradle.
> ---------------------------------------------------
>
> Key: BEAM-3942
> URL: https://issues.apache.org/jira/browse/BEAM-3942
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Chamikara Jayalath
> Assignee: Łukasz Gajowy
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> This requires performing updates to PerfKitBenchmarker and Beam so that we
> can execute performance tests using Gradle.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
