[
https://issues.apache.org/jira/browse/BEAM-3942?focusedWorklogId=88670&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88670
]
ASF GitHub Bot logged work on BEAM-3942:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Apr/18 02:10
Start Date: 07/Apr/18 02:10
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #5003:
[BEAM-3942] Update performance testing framework to use Gradle
URL: https://github.com/apache/beam/pull/5003#discussion_r179905523
##########
File path: build_rules.gradle
##########
@@ -593,6 +593,118 @@ ext.applyJavaNature = {
}
}
+// Reads and contains all necessary performance test parameters
+class JavaPerformanceTestConfiguration {
+ String pkbLocation = System.getProperty('pkbLocation')
+
+ String logLevel = System.getProperty('logLevel', 'INFO')
+ String gradleBinary = System.getProperty('gradleBinary', './gradlew')
+ String isOfficial = System.getProperty('official', 'true')
Review comment:
Do we want to default to `true` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 88670)
Time Spent: 1h 50m (was: 1h 40m)
> Update performance testing framework to use Gradle.
> ---------------------------------------------------
>
> Key: BEAM-3942
> URL: https://issues.apache.org/jira/browse/BEAM-3942
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Chamikara Jayalath
> Assignee: Łukasz Gajowy
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> This requires performing updates to PerfKitBenchmarker and Beam so that we
> can execute performance tests using Gradle.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
