[ https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=87806&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87806 ]
ASF GitHub Bot logged work on BEAM-3250: ---------------------------------------- Author: ASF GitHub Bot Created on: 04/Apr/18 23:12 Start Date: 04/Apr/18 23:12 Worklog Time Spent: 10m Work Description: lukecwik commented on a change in pull request #5025: [BEAM-3250] Migrate Apex and Gearpump ValidatesRunner tests to Gradle URL: https://github.com/apache/beam/pull/5025#discussion_r179309485 ########## File path: runners/gearpump/build.gradle ########## @@ -35,10 +43,40 @@ dependencies { shadow library.java.joda_time shadow library.java.jackson_annotations shadow library.java.findbugs_jsr305 - testCompile project(path: ":sdks:java:core", configuration: "shadowTest") - testCompile library.java.junit - testCompile library.java.hamcrest_core - testCompile library.java.jackson_databind - testCompile library.java.jackson_dataformat_yaml - testCompile library.java.mockito_core + shadowTest project(path: ":sdks:java:core", configuration: "shadowTest") + shadowTest library.java.junit + shadowTest library.java.hamcrest_core + shadowTest library.java.jackson_databind + shadowTest library.java.jackson_dataformat_yaml + shadowTest library.java.mockito_core + validatesRunner project(path: ":sdks:java:core", configuration: "shadowTest") + validatesRunner project(path: project.path, configuration: "shadow") +} + +task validatesRunnerStreaming (type: Test) { + group = "Verification" + systemProperty "beamTestPipelineOptions", JsonOutput.toJson([ + "--runner=TestGearpumpRunner", + "--streaming=true", + ]) + + classpath = configurations.validatesRunner + testClassesDirs = files(project(":sdks:java:core").sourceSets.test.output.classesDirs) + useJUnit { + includeCategories 'org.apache.beam.sdk.testing.ValidatesRunner' + excludeCategories 'org.apache.beam.sdk.testing.FlattenWithHeterogeneousCoders' Review comment: These seem like the wrong exclude categories when compared to https://github.com/apache/beam/blob/5caa883f191ca4cd9158694ae94a673edbc7b4d5/runners/gearpump/pom.xml#L72 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 87806) Time Spent: 1h 10m (was: 1h) > Migrate ValidatesRunner Jenkins PostCommits to Gradle > ----------------------------------------------------- > > Key: BEAM-3250 > URL: https://issues.apache.org/jira/browse/BEAM-3250 > Project: Beam > Issue Type: Sub-task > Components: build-system, testing > Reporter: Luke Cwik > Assignee: Henning Rohde > Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > Update these targets to execute ValidatesRunner tests: > https://github.com/apache/beam/search?l=Groovy&q=ValidatesRunner&type=&utf8=%E2%9C%93 -- This message was sent by Atlassian JIRA (v7.6.3#76005)