[
https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=87897&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87897
]
ASF GitHub Bot logged work on BEAM-3250:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Apr/18 06:04
Start Date: 05/Apr/18 06:04
Worklog Time Spent: 10m
Work Description: herohde commented on a change in pull request #5029:
[BEAM-3250] Migrate Dataflow ValidatesRunner test to Gradle
URL: https://github.com/apache/beam/pull/5029#discussion_r179356996
##########
File path: runners/google-cloud-dataflow-java/build.gradle
##########
@@ -70,23 +77,60 @@ dependencies {
shadow library.java.jackson_annotations
shadow library.java.jackson_databind
shadow library.java.slf4j_api
- testCompile library.java.hamcrest_core
- testCompile library.java.junit
- testCompile
project(":sdks:java:io:google-cloud-platform").sourceSets.test.output
- testCompile project(path: ":sdks:java:core", configuration: "shadowTest")
- testCompile
project(":sdks:java:extensions:google-cloud-platform-core").sourceSets.test.output
- testCompile library.java.guava_testlib
- testCompile library.java.slf4j_jdk14
- testCompile library.java.mockito_core
- testCompile library.java.google_cloud_dataflow_java_proto_library_all
- testCompile library.java.datastore_v1_protos
- testCompile library.java.jackson_dataformat_yaml
+ shadowTest library.java.hamcrest_core
+ shadowTest library.java.junit
+ shadowTest
project(":sdks:java:io:google-cloud-platform").sourceSets.test.output
+ shadowTest project(path: ":sdks:java:core", configuration: "shadowTest")
+ shadowTest
project(":sdks:java:extensions:google-cloud-platform-core").sourceSets.test.output
+ shadowTest library.java.guava_testlib
+ shadowTest library.java.slf4j_jdk14
+ shadowTest library.java.mockito_core
+ shadowTest library.java.google_cloud_dataflow_java_proto_library_all
+ shadowTest library.java.datastore_v1_protos
+ shadowTest library.java.jackson_dataformat_yaml
+ validatesRunner project(path: ":sdks:java:core", configuration: "shadowTest")
+ validatesRunner project(path: project.path, configuration: "shadow")
}
test {
systemProperties = [ "beamUseDummyRunner" : "true" ]
}
+task validatesRunnerTest(type: Test) {
+ group = "Verification"
+ def dataflowProject = project.findProperty('dataflowProject') ?:
'apache-beam-testing'
+ def dataflowTempRoot = project.findProperty('dataflowTempRoot') ?:
'gs://temp-storage-for-validates-runner-tests/'
+ systemProperty "beamTestPipelineOptions", JsonOutput.toJson([
+ "--runner=TestDataflowRunner",
+ "--project=${dataflowProject}",
+ "--tempRoot=${dataflowTempRoot}",
+ ])
+
+
+ classpath = configurations.validatesRunner
+ testClassesDirs =
files(project(":sdks:java:core").sourceSets.test.output.classesDirs)
+ useJUnit {
+ includeCategories 'org.apache.beam.sdk.testing.ValidatesRunner'
+ excludeCategories 'org.apache.beam.sdk.testing.LargeKeys$Above10MB'
Review comment:
I got it from here:
https://github.com/apache/beam/blob/a2a5d3d7aa59b5cfde1c47a6286bcb3ccd7f8c85/runners/google-cloud-dataflow-java/pom.xml#L283
Happy to remove them, if I misread the pom.
On a separate note, I see I missed the parallelism -- it's executing
sequentially (which was useful for testing it), but is not what we want in
Jenkins.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 87897)
Time Spent: 2.5h (was: 2h 20m)
> Migrate ValidatesRunner Jenkins PostCommits to Gradle
> -----------------------------------------------------
>
> Key: BEAM-3250
> URL: https://issues.apache.org/jira/browse/BEAM-3250
> Project: Beam
> Issue Type: Sub-task
> Components: build-system, testing
> Reporter: Luke Cwik
> Assignee: Henning Rohde
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Update these targets to execute ValidatesRunner tests:
> https://github.com/apache/beam/search?l=Groovy&q=ValidatesRunner&type=&utf8=%E2%9C%93
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
