[ 
https://issues.apache.org/jira/browse/BEAM-3995?focusedWorklogId=89097&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-89097
 ]

ASF GitHub Bot logged work on BEAM-3995:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Apr/18 20:10
            Start Date: 09/Apr/18 20:10
    Worklog Time Spent: 10m 
      Work Description: kennknowles commented on a change in pull request 
#5051: [BEAM-3995] Add basic DirectRunner Gradle run task to Nexmark
URL: https://github.com/apache/beam/pull/5051#discussion_r180214420
 
 

 ##########
 File path: sdks/java/nexmark/build.gradle
 ##########
 @@ -46,3 +46,14 @@ dependencies {
 test {
   jvmArgs "-da"
 }
+
+def nexmarkArgsProperty = "nexmark.args"
+
+task run (type: JavaExec) {
+  main = "org.apache.beam.sdk.nexmark.Main"
+  classpath = sourceSets.main.runtimeClasspath
 
 Review comment:
   Nexmark is not a test suite but a main application. Not sure if that changes 
your comment.
   
   I wanted to build a bundled artifact that included all transitive deps and 
was standalone. Needs one per runner, which is unfortunate but a natural 
consequence. The shaded configuration currently fails to include things like 
joda time when I switch it to `compile` so I abandoned the effort. I will 
resume it, actually, as I do like being able to run this way. Configuration per 
runner with dynamic classifier?
   
   Separately, what I am doing here is just using JavaExec to launch the main 
class. It isn't a library but an application so shading should be a noop when 
executed via JavaExec, is that not so? So I figure the non-bundled run should 
be entirely unshaded to save needless build.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 89097)
    Time Spent: 1h 20m  (was: 1h 10m)

> Launch Nexmark suites from gradle and update web page docs
> ----------------------------------------------------------
>
>                 Key: BEAM-3995
>                 URL: https://issues.apache.org/jira/browse/BEAM-3995
>             Project: Beam
>          Issue Type: Sub-task
>          Components: examples-nexmark, website
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>            Priority: Major
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Currently our instructions for running Nexmark benchmarks on various runners 
> is pretty tightly tied to Maven. We need a good story for running them with 
> gradle (or just building an executable with gradle and running that 
> standalone).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to