ASF GitHub Bot logged work on BEAM-3995:

                Author: ASF GitHub Bot
            Created on: 09/Apr/18 20:31
            Start Date: 09/Apr/18 20:31
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on a change in pull request #5051: 
[BEAM-3995] Add basic DirectRunner Gradle run task to Nexmark
URL: https://github.com/apache/beam/pull/5051#discussion_r180218636

 File path: sdks/java/nexmark/build.gradle
 @@ -46,3 +46,14 @@ dependencies {
 test {
   jvmArgs "-da"
+def nexmarkArgsProperty = "nexmark.args"
+task run (type: JavaExec) {
+  main = "org.apache.beam.sdk.nexmark.Main"
+  classpath = sourceSets.main.runtimeClasspath
 Review comment:
   The reason why I suggested to run using the shaded artifacts is that it 
would match what users would be running if they depended on the Apache Beam 
nexmark artifact distributed via Maven central.
   Also, if you want to integrate nexmark into the perf/integration testing it 
would seem like you would want to run it using gradle and not have to build a 
shell script to first build the bundled jar and then execute it using java.
   Having a separate configuration per runner makes sense if a runner needs 
additional overrides (typical of spark) to get it to work with Nexmark because 
of a dependency conflict.
   Configuration per runner with dynamic classifier?
   configuration {
   dependencies {
     nexmarkRun project(name: project.path, configuration: 'shadow')
     nexmarkRun project(name: runnerToUse, configuration: 'shadow')
   task run(type: JavaExec) {
     classpath = configurations.nexmarkRun
   Run via `./gradlew -p sdks/java/nexmark run 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 89113)
    Time Spent: 2h  (was: 1h 50m)

> Launch Nexmark suites from gradle and update web page docs
> ----------------------------------------------------------
>                 Key: BEAM-3995
>                 URL: https://issues.apache.org/jira/browse/BEAM-3995
>             Project: Beam
>          Issue Type: Sub-task
>          Components: examples-nexmark, website
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>            Priority: Major
>          Time Spent: 2h
>  Remaining Estimate: 0h
> Currently our instructions for running Nexmark benchmarks on various runners 
> is pretty tightly tied to Maven. We need a good story for running them with 
> gradle (or just building an executable with gradle and running that 
> standalone).

This message was sent by Atlassian JIRA

Reply via email to