[ https://issues.apache.org/jira/browse/BEAM-3119?focusedWorklogId=89197&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-89197 ]
ASF GitHub Bot logged work on BEAM-3119: ---------------------------------------- Author: ASF GitHub Bot Created on: 09/Apr/18 23:45 Start Date: 09/Apr/18 23:45 Worklog Time Spent: 10m Work Description: tgroh commented on a change in pull request #4965: BEAM-3119 ensure the metrics thread pool is related to an execution URL: https://github.com/apache/beam/pull/4965#discussion_r180261005 ########## File path: runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectRunner.java ########## @@ -172,48 +176,53 @@ public DirectPipelineResult run(Pipeline originalPipeline) { } pipeline.replaceAll(defaultTransformOverrides()); MetricsEnvironment.setMetricsSupported(true); - DirectGraphVisitor graphVisitor = new DirectGraphVisitor(); - pipeline.traverseTopologically(graphVisitor); + try { + DirectGraphVisitor graphVisitor = new DirectGraphVisitor(); + pipeline.traverseTopologically(graphVisitor); - @SuppressWarnings("rawtypes") - KeyedPValueTrackingVisitor keyedPValueVisitor = KeyedPValueTrackingVisitor.create(); - pipeline.traverseTopologically(keyedPValueVisitor); + @SuppressWarnings("rawtypes") + KeyedPValueTrackingVisitor keyedPValueVisitor = KeyedPValueTrackingVisitor.create(); + pipeline.traverseTopologically(keyedPValueVisitor); - DisplayDataValidator.validatePipeline(pipeline); - DisplayDataValidator.validateOptions(getPipelineOptions()); + DisplayDataValidator.validatePipeline(pipeline); + DisplayDataValidator.validateOptions(getPipelineOptions()); - DirectGraph graph = graphVisitor.getGraph(); - EvaluationContext context = - EvaluationContext.create( - getPipelineOptions(), - clockSupplier.get(), - Enforcement.bundleFactoryFor(enabledEnforcements, graph), - graph, - keyedPValueVisitor.getKeyedPValues()); + DirectGraph graph = graphVisitor.getGraph(); + ExecutorService metricsPool = Executors.newCachedThreadPool( + new ThreadFactoryBuilder() + .setThreadFactory(MoreExecutors.platformThreadFactory()) + .setDaemon(false) // otherwise you say you want to leak, please don't! + .setNameFormat("direct-metrics-counter-committer") + .build()); + EvaluationContext context = EvaluationContext.create( + getPipelineOptions(), clockSupplier.get(), Review comment: This formatting is off. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 89197) Time Spent: 2h (was: 1h 50m) > direct-metrics-counter-committer threads are leaking > ---------------------------------------------------- > > Key: BEAM-3119 > URL: https://issues.apache.org/jira/browse/BEAM-3119 > Project: Beam > Issue Type: Bug > Components: runner-direct > Reporter: Etienne Chauchot > Assignee: Thomas Groh > Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > When I run ElasticsearchIOTests using ESv5, there is a thread leak control > mechanism ({{com.carrotsearch.randomizedtesting.ThreadLeakControl}}). It > waits for 5s for non-terminated threads at the end of a test. It detects > leaked {{direct-metrics-counter-committer}} thread. > {code} > com.carrotsearch.randomizedtesting.ThreadLeakError: There are still zombie > threads that couldn't be terminated: > 1) Thread[id=296, name=direct-metrics-counter-committer, > state=TIMED_WAITING, group=TGRP-ElasticsearchIOTest] > at sun.misc.Unsafe.park(Native Method) > at > java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215) > at > java.util.concurrent.SynchronousQueue$TransferStack.awaitFulfill(SynchronousQueue.java:460) > at > java.util.concurrent.SynchronousQueue$TransferStack.transfer(SynchronousQueue.java:362) > at > java.util.concurrent.SynchronousQueue.poll(SynchronousQueue.java:941) > at > java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1066) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1127) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > at __randomizedtesting.SeedInfo.seed([59E504CA1B0DD6A8]:0){code} > I tried to increase the timeout to 30s (by patching > randomizedtesting-runner-2.5.0.jar) but still gets a zombie thread. > To reproduce, just comment > {code} > @ThreadLeakScope(ThreadLeakScope.Scope.NONE) > {code} > in > {code} > beam/sdks/java/io/elasticsearch-tests/elasticsearch-tests-5/src/test/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIOTest.java > {code} > and run > {code} > testRead() > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)