[
https://issues.apache.org/jira/browse/BEAM-3479?focusedWorklogId=89539&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-89539
]
ASF GitHub Bot logged work on BEAM-3479:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Apr/18 18:23
Start Date: 10/Apr/18 18:23
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#4412: [BEAM-3479] adding a test to ensure the right classloader is used to
defined the dofninvoker
URL: https://github.com/apache/beam/pull/4412#discussion_r180519768
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/StableInvokerNamingStrategy.java
##########
@@ -31,6 +31,8 @@
*/
@AutoValue
abstract class StableInvokerNamingStrategy extends NamingStrategy.AbstractBase
{
+ /** $ is for a nested class so use as most proxying framework $$. */
+ static final Object PROXY_NAME_DELIMITER = "$$";
Review comment:
`@VisibleForTesting`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 89539)
Time Spent: 1.5h (was: 1h 20m)
> Add a regression test for the DoFn classloader selection
> --------------------------------------------------------
>
> Key: BEAM-3479
> URL: https://issues.apache.org/jira/browse/BEAM-3479
> Project: Beam
> Issue Type: Task
> Components: sdk-java-core
> Reporter: Romain Manni-Bucau
> Assignee: Romain Manni-Bucau
> Priority: Major
> Fix For: 2.5.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Follow up task after https://github.com/apache/beam/pull/4235 merge. This
> task is about ensuring we test that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
