[
https://issues.apache.org/jira/browse/BEAM-3479?focusedWorklogId=89537&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-89537
]
ASF GitHub Bot logged work on BEAM-3479:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Apr/18 18:23
Start Date: 10/Apr/18 18:23
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#4412: [BEAM-3479] adding a test to ensure the right classloader is used to
defined the dofninvoker
URL: https://github.com/apache/beam/pull/4412#discussion_r180519642
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/ByteBuddyDoFnInvokerFactory.java
##########
@@ -94,6 +94,7 @@
public static final String RESTRICTION_TRACKER_PARAMETER_METHOD =
"restrictionTracker";
public static final String STATE_PARAMETER_METHOD = "state";
public static final String TIMER_PARAMETER_METHOD = "timer";
+ static final String PROXY_CLASSNAME_SUFFIX =
DoFnInvoker.class.getSimpleName();
Review comment:
`@VisibleForTesting`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 89537)
> Add a regression test for the DoFn classloader selection
> --------------------------------------------------------
>
> Key: BEAM-3479
> URL: https://issues.apache.org/jira/browse/BEAM-3479
> Project: Beam
> Issue Type: Task
> Components: sdk-java-core
> Reporter: Romain Manni-Bucau
> Assignee: Romain Manni-Bucau
> Priority: Major
> Fix For: 2.5.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Follow up task after https://github.com/apache/beam/pull/4235 merge. This
> task is about ensuring we test that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
