[ https://issues.apache.org/jira/browse/BEAM-2990?focusedWorklogId=89560&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-89560 ]
ASF GitHub Bot logged work on BEAM-2990: ---------------------------------------- Author: ASF GitHub Bot Created on: 10/Apr/18 19:09 Start Date: 10/Apr/18 19:09 Worklog Time Spent: 10m Work Description: XuMingmin commented on a change in pull request #5079: [BEAM-2990] support MAP in SQL schema URL: https://github.com/apache/beam/pull/5079#discussion_r180536469 ########## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/Schema.java ########## @@ -242,6 +247,10 @@ public FieldType type() { public abstract TypeName getTypeName(); // For container types (e.g. ARRAY), returns the type of the contained element. @Nullable public abstract FieldType getComponentType(); + // For MAP type, returns the type of the key element. + @Nullable public abstract FieldType getComponentKeyType(); + // For MAP type, returns the type of the value element. + @Nullable public abstract FieldType getComponentValueType(); Review comment: I would prefer to have different fields for MAP and ARRAY, if it doesn't cause significant performance issue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 89560) Time Spent: 1h (was: 50m) > support data type MAP > --------------------- > > Key: BEAM-2990 > URL: https://issues.apache.org/jira/browse/BEAM-2990 > Project: Beam > Issue Type: New Feature > Components: dsl-sql > Reporter: Xu Mingmin > Assignee: Xu Mingmin > Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > support Non-scalar types: > MAP Collection of keys mapped to values > ARRAY Ordered, contiguous collection that may contain duplicates -- This message was sent by Atlassian JIRA (v7.6.3#76005)