[ 
https://issues.apache.org/jira/browse/BEAM-2990?focusedWorklogId=89879&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-89879
 ]

ASF GitHub Bot logged work on BEAM-2990:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Apr/18 10:25
            Start Date: 11/Apr/18 10:25
    Worklog Time Spent: 10m 
      Work Description: reuvenlax commented on a change in pull request #5079: 
[BEAM-2990] support MAP in SQL schema
URL: https://github.com/apache/beam/pull/5079#discussion_r180705565
 
 

 ##########
 File path: sdks/java/core/src/test/java/org/apache/beam/sdk/values/RowTest.java
 ##########
 @@ -174,6 +176,24 @@ public void testCreatesArrayArray() {
     assertEquals(data, row.getArray("array"));
   }
 
+  @Test
+  public void testCreatesMap() {
+    Map<Integer, String> data = new HashMap<Integer, String>() {
+      {
+        put(1, "value1");
+        put(2, "value2");
+        put(3, "value3");
+        put(4, "value4");
 
 Review comment:
   <!--new_thread; commit:7bf9d2048e8d568ee9280629db391775cc490358; 
resolved:0-->
   I would also add a test where the map value is itself a complex or nested 
type.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 89879)
    Time Spent: 1h 50m  (was: 1h 40m)

> support data type MAP
> ---------------------
>
>                 Key: BEAM-2990
>                 URL: https://issues.apache.org/jira/browse/BEAM-2990
>             Project: Beam
>          Issue Type: New Feature
>          Components: dsl-sql
>            Reporter: Xu Mingmin
>            Assignee: Xu Mingmin
>            Priority: Major
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> support Non-scalar types:
> MAP   Collection of keys mapped to values
> ARRAY         Ordered, contiguous collection that may contain duplicates



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to