[ 
https://issues.apache.org/jira/browse/BEAM-4044?focusedWorklogId=89708&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-89708
 ]

ASF GitHub Bot logged work on BEAM-4044:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Apr/18 23:37
            Start Date: 10/Apr/18 23:37
    Worklog Time Spent: 10m 
      Work Description: akedin commented on a change in pull request #5040: 
[BEAM-4044] [SQL] Refresh DDL from 1.16
URL: https://github.com/apache/beam/pull/5040#discussion_r180598326
 
 

 ##########
 File path: 
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/kafka/KafkaTableProviderTest.java
 ##########
 @@ -65,17 +64,17 @@ private static Table mockTable(String name) {
     return Table.builder()
         .name(name)
         .comment(name + " table")
-        .location(URI.create("kafka://localhost:2181/brokers?topic=test"))
+        .location("kafka://localhost:2181/brokers?topic=test")
 
 Review comment:
   Got it. The #4991 doesn't show any BQ-specific examples so this wasn't 
clear. How do we know that the table is a BQ table then if we can't use 
Location to identify it?
   
   And I think that URI format actually supports the syntax for BQ table IDs, 
but not sure how semantically correct that would be. It would probably 
technically be a URN at that point which our code has to resolve using some 
other data.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 89708)
    Time Spent: 1.5h  (was: 1h 20m)

> Take advantage of Calcite DDL
> -----------------------------
>
>                 Key: BEAM-4044
>                 URL: https://issues.apache.org/jira/browse/BEAM-4044
>             Project: Beam
>          Issue Type: New Feature
>          Components: dsl-sql
>            Reporter: Andrew Pilloud
>            Assignee: Andrew Pilloud
>            Priority: Major
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> In Calcite 1.15 support for abstract DDL moved into calcite core. We should 
> take advantage of that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to