[
https://issues.apache.org/jira/browse/BEAM-4044?focusedWorklogId=89717&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-89717
]
ASF GitHub Bot logged work on BEAM-4044:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Apr/18 23:46
Start Date: 10/Apr/18 23:46
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #5040:
[BEAM-4044] [SQL] Refresh DDL from 1.16
URL: https://github.com/apache/beam/pull/5040#discussion_r180599529
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/kafka/KafkaTableProviderTest.java
##########
@@ -65,17 +64,17 @@ private static Table mockTable(String name) {
return Table.builder()
.name(name)
.comment(name + " table")
- .location(URI.create("kafka://localhost:2181/brokers?topic=test"))
+ .location("kafka://localhost:2181/brokers?topic=test")
Review comment:
The DDL already requires a type. Syntax for this looks something like
`CREATE TABLE mytable TYPE kafka LOCATION
"kafka://localhost:2181/brokers?topic=test"`
PR #4991 links to #4947 which adds bigquery. I was honestly expecting both
to be merged before this one was reviewed, but I haven't been able to get
reviews on #4991.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 89717)
Time Spent: 1h 40m (was: 1.5h)
> Take advantage of Calcite DDL
> -----------------------------
>
> Key: BEAM-4044
> URL: https://issues.apache.org/jira/browse/BEAM-4044
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Andrew Pilloud
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> In Calcite 1.15 support for abstract DDL moved into calcite core. We should
> take advantage of that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
