[ 
https://issues.apache.org/jira/browse/BEAM-3981?focusedWorklogId=89868&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-89868
 ]

ASF GitHub Bot logged work on BEAM-3981:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Apr/18 09:46
            Start Date: 11/Apr/18 09:46
    Worklog Time Spent: 10m 
      Work Description: RobbeSneyders commented on issue #5053: [BEAM-3981] 
Futurize coders subpackage
URL: https://github.com/apache/beam/pull/5053#issuecomment-380393283
 
 
   Working on some other subpackages, I've come across an additional reason to 
upgrade the cython version. 
   
   Currently, the `__cmp__` method is used in cythonized python files instead 
of the `__eq__` method because cython did not support the `__eq__` or any other 
special comparison methods. In Python 3, support for `__cmp__` is gone, so this 
workaround will not work anymore.
   
   [Cython has added support for the special comparison methods in version 
0.27.0](http://cython.readthedocs.io/en/latest/src/userguide/special_methods.html#rich-comparisons),
 which allows us to use `__eq__` again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 89868)
    Time Spent: 6h 50m  (was: 6h 40m)

> Futurize and fix python 2 compatibility for coders package
> ----------------------------------------------------------
>
>                 Key: BEAM-3981
>                 URL: https://issues.apache.org/jira/browse/BEAM-3981
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Robbe
>            Assignee: Ahmet Altay
>            Priority: Major
>          Time Spent: 6h 50m
>  Remaining Estimate: 0h
>
> Run automatic conversion with futurize tool on coders subpackage and fix 
> python 2 compatibility. This prepares the subpackage for python 3 support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to