ASF GitHub Bot logged work on BEAM-3942:

                Author: ASF GitHub Bot
            Created on: 12/Apr/18 01:08
            Start Date: 12/Apr/18 01:08
    Worklog Time Spent: 10m 
      Work Description: chamikaramj commented on a change in pull request 
#5003: [BEAM-3942] Update performance testing framework to use Gradle
URL: https://github.com/apache/beam/pull/5003#discussion_r180940678

 File path: build_rules.gradle
 @@ -593,6 +593,118 @@ ext.applyJavaNature = {
+// Reads and contains all necessary performance test parameters
+class JavaPerformanceTestConfiguration {
+  String pkbLocation = System.getProperty('pkbLocation')
+  String logLevel = System.getProperty('logLevel', 'INFO')
+  String gradleBinary = System.getProperty('gradleBinary', './gradlew')
+  String isOfficial = System.getProperty('official', 'true')
+  String benchmarks = System.getProperty('benchmarks', 
+  String beamPrebuilt = System.getProperty('beamPrebuilt', 'true')
+  String beamSdk = System.getProperty('beamSdk', 'java')
+  String timeout = System.getProperty('itTimeout', '1200')
+  String kubeconfig = System.getProperty('kubeconfig', 
System.getProperty('user.home') + '/.kube/config')
+  String kubectl = System.getProperty('kubectl', 'kubectl')
+  // PerfKit will have trouble reading 'null' path. It expects empty string if 
no scripts are expected.
 Review comment:
commit:eebddd5f85b675523294b22a3efe8e110c8d145e; resolved:1-->
   > **lgajowy** wrote:
   > I think we can fix this on the perfkit side but I rather tend to think it 
should be done in separate PR. I wanted to change the least possible amount of 
code in perfkit to integrate with gradle and then improve. Do you agree with me?
   Sounds good.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 90250)
    Time Spent: 8h  (was: 7h 50m)

> Update performance testing framework to use Gradle.
> ---------------------------------------------------
>                 Key: BEAM-3942
>                 URL: https://issues.apache.org/jira/browse/BEAM-3942
>             Project: Beam
>          Issue Type: Sub-task
>          Components: testing
>            Reporter: Chamikara Jayalath
>            Assignee: Ɓukasz Gajowy
>            Priority: Major
>          Time Spent: 8h
>  Remaining Estimate: 0h
> This requires performing updates to PerfKitBenchmarker and Beam so that we 
> can execute performance tests using Gradle.

This message was sent by Atlassian JIRA

Reply via email to