ASF GitHub Bot logged work on BEAM-3942:

                Author: ASF GitHub Bot
            Created on: 10/Apr/18 14:42
            Start Date: 10/Apr/18 14:42
    Worklog Time Spent: 10m 
      Work Description: lgajowy commented on a change in pull request #5003: 
[BEAM-3942] Update performance testing framework to use Gradle
URL: https://github.com/apache/beam/pull/5003#discussion_r180447086

 File path: 
 @@ -47,18 +47,16 @@
  * <p>This test requires a running instance of Postgres. Pass in connection 
information using
  * PipelineOptions:
  * <pre>
- *  mvn -e -Pio-it verify -pl sdks/java/io/jdbc 
+ *  ./gradlew integrationTest -p sdks/java/io/jdbc 
  *  "--postgresServerName=",
  *  "--postgresUsername=postgres",
  *  "--postgresDatabaseName=myfancydb",
  *  "--postgresPassword=mypass",
  *  "--postgresSsl=false",
  *  "--numberOfRecords=1000" ]'
+ *  --tests org.apache.beam.sdk.io.jdbc.JdbcIOIT
  * </pre>
- * <p>If you want to run this with a runner besides directrunner, there are 
profiles for dataflow
- * and spark in the jdbc pom. You'll want to activate those in addition to the 
normal test runner
 Review comment:
   Indeed, it does not -  we were not able to run spark even though there was a 
profile for it. I added a more descriptive comment in following commit. 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 89428)
    Time Spent: 6h  (was: 5h 50m)

> Update performance testing framework to use Gradle.
> ---------------------------------------------------
>                 Key: BEAM-3942
>                 URL: https://issues.apache.org/jira/browse/BEAM-3942
>             Project: Beam
>          Issue Type: Sub-task
>          Components: testing
>            Reporter: Chamikara Jayalath
>            Assignee: Ɓukasz Gajowy
>            Priority: Major
>          Time Spent: 6h
>  Remaining Estimate: 0h
> This requires performing updates to PerfKitBenchmarker and Beam so that we 
> can execute performance tests using Gradle.

This message was sent by Atlassian JIRA

Reply via email to