[ 
https://issues.apache.org/jira/browse/BEAM-4011?focusedWorklogId=90516&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-90516
 ]

ASF GitHub Bot logged work on BEAM-4011:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Apr/18 18:15
            Start Date: 12/Apr/18 18:15
    Worklog Time Spent: 10m 
      Work Description: chamikaramj commented on a change in pull request 
#5024: [BEAM-4011] Unify Python IO glob implementation.
URL: https://github.com/apache/beam/pull/5024#discussion_r181165982
 
 

 ##########
 File path: sdks/python/apache_beam/io/filesystem.py
 ##########
 @@ -498,9 +501,47 @@ def mkdirs(self, path):
     raise NotImplementedError
 
   @abc.abstractmethod
+  def has_dirs(self):
+    """Whether this FileSystem supports directories."""
+    raise NotImplementedError
+
+  @abc.abstractmethod
+  def list(self, dir_or_prefix):
 
 Review comment:
   I think having both list() and match() as public can be confusing to users. 
Let's keep list() as private (and move it to filesystem implementations)  if 
there's no compelling use-case to keep it in the interface.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 90516)
    Time Spent: 1h 20m  (was: 1h 10m)

> Python SDK: add glob support for HDFS
> -------------------------------------
>
>                 Key: BEAM-4011
>                 URL: https://issues.apache.org/jira/browse/BEAM-4011
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Udi Meiri
>            Assignee: Udi Meiri
>            Priority: Major
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to