[
https://issues.apache.org/jira/browse/BEAM-4011?focusedWorklogId=90664&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-90664
]
ASF GitHub Bot logged work on BEAM-4011:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Apr/18 01:30
Start Date: 13/Apr/18 01:30
Worklog Time Spent: 10m
Work Description: udim commented on a change in pull request #5024:
[BEAM-4011] Unify Python IO glob implementation.
URL: https://github.com/apache/beam/pull/5024#discussion_r181265403
##########
File path: sdks/python/apache_beam/io/filesystem.py
##########
@@ -579,6 +661,19 @@ def exists(self, path):
raise NotImplementedError
@abc.abstractmethod
+ def size(self, path):
Review comment:
_list() returns sizes, but it only works on prefixes (may return more than
one result) or directories (fails on files).
I added this method for the case where the pattern given doesn't end in `/`
and has no globbing characters. In this case we return the size of the file or
directory pointed to by the pattern (if it exists).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 90664)
Time Spent: 2h (was: 1h 50m)
> Python SDK: add glob support for HDFS
> -------------------------------------
>
> Key: BEAM-4011
> URL: https://issues.apache.org/jira/browse/BEAM-4011
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Udi Meiri
> Assignee: Udi Meiri
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
