[
https://issues.apache.org/jira/browse/BEAM-3995?focusedWorklogId=90565&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-90565
]
ASF GitHub Bot logged work on BEAM-3995:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Apr/18 20:36
Start Date: 12/Apr/18 20:36
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request #418:
[BEAM-3995] Update Nexmark launch instructions for Gradle
URL: https://github.com/apache/beam-site/pull/418#discussion_r181213684
##########
File path: src/documentation/sdks/nexmark.md
##########
@@ -417,124 +429,192 @@ Yet to come
### Running SMOKE suite on the DirectRunner (local)
+The DirectRunner is default, so it is not required to pass `-Pnexmark.runner`.
+Here we do it for maximum clarity.
+
+The direct runner does not have separate batch and streaming modes, but the
+Nexmark launch does.
+
+These parameters leave on many of the DirectRunner's extra safety checks so the
+SMOKE suite can make sure there is nothing broken in the Nexmark suite.
+
Batch Mode:
- mvn exec:java -Dexec.mainClass=org.apache.beam.sdk.nexmark.Main
-Pdirect-runner -Dexec.args="--runner=DirectRunner --suite=SMOKE
--streaming=false --manageResources=false --monitorJobs=true
--enforceEncodability=true --enforceImmutability=true"
+ ./gradlew :beam-sdks-java-nexmark:run \
+ -Pnexmark.runner=":beam-runners-direct-java" \
+ -Pnexmark.args="
+ --runner=DirectRunner
+ --streaming=false
+ --suite=SMOKE
+ --manageResources=false
+ --monitorJobs=true
+ --enforceEncodability=true
+ --enforceImmutability=true"
Streaming Mode:
- mvn exec:java -Dexec.mainClass=org.apache.beam.sdk.nexmark.Main
-Pdirect-runner -Dexec.args="--runner=DirectRunner --suite=SMOKE
--streaming=true --manageResources=false --monitorJobs=true
--enforceEncodability=true --enforceImmutability=true"
-
+ ./gradlew :beam-sdks-java-nexmark:run \
+ -Pnexmark.runner=":beam-runners-direct-java" \
+ -Pnexmark.args="
+ --runner=DirectRunner
+ --streaming=true
+ --suite=SMOKE
+ --manageResources=false
+ --monitorJobs=true
+ --enforceEncodability=true
+ --enforceImmutability=true"
### Running SMOKE suite on the SparkRunner (local)
+The SparkRunner is special-cased in the Nexmark gradle launch. The task will
+provide the version of Spark that the SparkRunner is built against, and
+configure logging.
Review comment:
This is a comment about the hardcoding above. The nexmark build tweaks the
dependencies based on special needs of the SparkRunner instead of being just a
generic suite of pipelines. I will delete the comment here since it "just
works" for users copying and pasting from here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 90565)
Time Spent: 8h 10m (was: 8h)
> Launch Nexmark suites from gradle and update web page docs
> ----------------------------------------------------------
>
> Key: BEAM-3995
> URL: https://issues.apache.org/jira/browse/BEAM-3995
> Project: Beam
> Issue Type: Sub-task
> Components: examples-nexmark, website
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 8h 10m
> Remaining Estimate: 0h
>
> Currently our instructions for running Nexmark benchmarks on various runners
> is pretty tightly tied to Maven. We need a good story for running them with
> gradle (or just building an executable with gradle and running that
> standalone).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
