[
https://issues.apache.org/jira/browse/BEAM-3995?focusedWorklogId=90566&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-90566
]
ASF GitHub Bot logged work on BEAM-3995:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Apr/18 20:36
Start Date: 12/Apr/18 20:36
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request #418:
[BEAM-3995] Update Nexmark launch instructions for Gradle
URL: https://github.com/apache/beam-site/pull/418#discussion_r181212848
##########
File path: src/documentation/sdks/nexmark.md
##########
@@ -112,17 +122,19 @@ Performance:
## Benchmark launch configuration
-We can specify the Beam runner to use with maven profiles, available profiles
are:
-
- direct-runner
- spark-runner
- flink-runner
- apex-runner
+The Nexmark launcher accepts the `--runner` argument as usual for programs that
+use Beam PipelineOptions to manage their command line arguments. In addition
+to this, the necessary dependencies must be configured.
-The runner must also be specified like in any other Beam pipeline using:
+When running via Gradle, the following two parameters control the execution:
- --runner
+ -P nexmark.args
+ The command line to pass to the Nexmark main program.
+ -P nexmark.runner
Review comment:
Yes, Gradle puts them on the classpath. The one exception is the Spark
runner. I used to have a `-P nexmark.provideSpark` parameter to keep it a
little decoupled, but since it is pretty much still "magic" knowledge, I
followed @lukecwik's suggestion and just hardcoded knowledge of the dependency,
so I did that
[here](https://github.com/apache/beam/blob/master/sdks/java/nexmark/build.gradle#L35).
I think when I add the fat jar capability it may require a separate fat jar
for each known runner config. At that point, pretending that the runner
dependency can be anything (versus a selection of a hardcoded profile) may not
be useful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 90566)
Time Spent: 8h 20m (was: 8h 10m)
> Launch Nexmark suites from gradle and update web page docs
> ----------------------------------------------------------
>
> Key: BEAM-3995
> URL: https://issues.apache.org/jira/browse/BEAM-3995
> Project: Beam
> Issue Type: Sub-task
> Components: examples-nexmark, website
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 8h 20m
> Remaining Estimate: 0h
>
> Currently our instructions for running Nexmark benchmarks on various runners
> is pretty tightly tied to Maven. We need a good story for running them with
> gradle (or just building an executable with gradle and running that
> standalone).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
