[ 
https://issues.apache.org/jira/browse/BEAM-3856?focusedWorklogId=91015&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-91015
 ]

ASF GitHub Bot logged work on BEAM-3856:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Apr/18 23:20
            Start Date: 13/Apr/18 23:20
    Worklog Time Spent: 10m 
      Work Description: wcn3 commented on a change in pull request #4939: 
[BEAM-3856][BEAM-3854] Add prototype of Go streaming on Dataflow with PubSub
URL: https://github.com/apache/beam/pull/4939#discussion_r181528869
 
 

 ##########
 File path: sdks/go/pkg/beam/runners/dataflow/translate.go
 ##########
 @@ -351,6 +363,45 @@ func translateEdge(edge *graph.MultiEdge) (string, 
properties, error) {
                        UserName: buildName(edge.Scope(), "flatten"), // TODO: 
user-defined
                }, nil
 
+       case graph.External:
 
 Review comment:
   To support the open/closed principle, it would be nice if we could have 
modules register a function to be called for a certain URN. This would leave 
the translator intact, and new external payload types would be self-injecting.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 91015)
    Time Spent: 2h  (was: 1h 50m)

> Add prototype support for Go SDK streaming
> ------------------------------------------
>
>                 Key: BEAM-3856
>                 URL: https://issues.apache.org/jira/browse/BEAM-3856
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-go
>            Reporter: Willy Lulciuc
>            Assignee: Henning Rohde
>            Priority: Major
>          Time Spent: 2h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to