[
https://issues.apache.org/jira/browse/BEAM-3856?focusedWorklogId=91829&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-91829
]
ASF GitHub Bot logged work on BEAM-3856:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/18 17:05
Start Date: 17/Apr/18 17:05
Worklog Time Spent: 10m
Work Description: herohde commented on a change in pull request #4939:
[BEAM-3856][BEAM-3854] Add prototype of Go streaming on Dataflow with PubSub
URL: https://github.com/apache/beam/pull/4939#discussion_r182156926
##########
File path: sdks/go/pkg/beam/runners/dataflow/translate.go
##########
@@ -351,6 +363,45 @@ func translateEdge(edge *graph.MultiEdge) (string,
properties, error) {
UserName: buildName(edge.Scope(), "flatten"), // TODO:
user-defined
}, nil
+ case graph.External:
Review comment:
Ack. The Dataflow translation won't likely change further and any other
interpretation of the external payloads would have to be supported by the
underlying engine. Instead of adding a stateful registration to an otherwise
pure translation, substitutions in the proto pipeline would be a preferable way
to go long term.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 91829)
Time Spent: 2h 10m (was: 2h)
> Add prototype support for Go SDK streaming
> ------------------------------------------
>
> Key: BEAM-3856
> URL: https://issues.apache.org/jira/browse/BEAM-3856
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Willy Lulciuc
> Assignee: Henning Rohde
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
