[ 
https://issues.apache.org/jira/browse/BEAM-4093?focusedWorklogId=91545&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-91545
 ]

ASF GitHub Bot logged work on BEAM-4093:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Apr/18 23:21
            Start Date: 16/Apr/18 23:21
    Worklog Time Spent: 10m 
      Work Description: markflyhigh opened a new pull request #5147: 
[BEAM-4093] Support Python ValidatesRunner test in streaming
URL: https://github.com/apache/beam/pull/5147
 
 
   Improved `TestDataflowRunner` so that ValidatesRunner tests can run in 
streaming mode against it by specify `--wait_until_finish_duration` from 
commandline. Since streaming pipeline cannot terminate itself, framework will 
cancel the job after `wait_until_finish_duration` time.
   
   Note: This change only enables basic level of verification to the streaming 
job. Any failures that lead to unsuccessful termination state (like FAILED) 
will be caught and cause test fail. However, `asser_that` failures cannot be 
caught at this time.
   
   ------------------------
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
    - [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the 
change (usually before you start working on it).  Trivial changes like typos do 
not require a JIRA issue.  Your pull request should address just this issue, 
without pulling in other changes.
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA 
issue.
    - [ ] Write a pull request description that is detailed enough to 
understand:
      - [ ] What the pull request does
      - [ ] Why it does it
      - [ ] How it does it
      - [ ] Why this approach
    - [ ] Each commit in the pull request should have a meaningful subject line 
and body.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 91545)
            Time Spent: 10m
    Remaining Estimate: 0h

> Support Python ValidatesRunner test against TestDataflowRunner in streaming
> ---------------------------------------------------------------------------
>
>                 Key: BEAM-4093
>                 URL: https://issues.apache.org/jira/browse/BEAM-4093
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-py-core, testing
>            Reporter: Mark Liu
>            Assignee: Mark Liu
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to