[
https://issues.apache.org/jira/browse/BEAM-4093?focusedWorklogId=92027&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-92027
]
ASF GitHub Bot logged work on BEAM-4093:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Apr/18 02:00
Start Date: 18/Apr/18 02:00
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #5147:
[BEAM-4093] Support Python ValidatesRunner test in streaming
URL: https://github.com/apache/beam/pull/5147#discussion_r182290272
##########
File path: sdks/python/apache_beam/runners/dataflow/test_dataflow_runner.py
##########
@@ -37,10 +38,13 @@ def run_pipeline(self, pipeline):
"""Execute test pipeline and verify test matcher"""
options = pipeline._options.view_as(TestOptions)
on_success_matcher = options.on_success_matcher
+ wait_duration = options.wait_until_finish_duration
+ is_streaming = options.view_as(StandardOptions).streaming
# [BEAM-1889] Do not send this to remote workers also, there is no need to
# send this option to remote executors.
options.on_success_matcher = None
+ options.wait_until_finish_duration = None
Review comment:
Do you need this here? I do not think this this is necessary based on
BEAM-1889?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 92027)
Time Spent: 0.5h (was: 20m)
> Support Python ValidatesRunner test against TestDataflowRunner in streaming
> ---------------------------------------------------------------------------
>
> Key: BEAM-4093
> URL: https://issues.apache.org/jira/browse/BEAM-4093
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core, testing
> Reporter: Mark Liu
> Assignee: Mark Liu
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
