[
https://issues.apache.org/jira/browse/BEAM-3697?focusedWorklogId=91959&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-91959
]
ASF GitHub Bot logged work on BEAM-3697:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/18 22:53
Start Date: 17/Apr/18 22:53
Worklog Time Spent: 10m
Work Description: kennknowles opened a new pull request #5161:
[BEAM-3697] Add errorprone to Gradle build
URL: https://github.com/apache/beam/pull/5161
This adds the nice errorprone tool to our builds. It is faster and more
meaningful than findbugs. If this gets in, I would drop findbugs to save
analysis time and false warnings.
I have run this tool over the codebase and there are lots of actual bugs. I
fixed the ones deemed "error" in the core SDK. Likely Jenkins will hit a few
more and I will fix them.
It also uncovered a minor issue with our Gradle config that I have worked
around as it will take more work to actually redesign the build.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [ ] Write a pull request description that is detailed enough to
understand:
- [ ] What the pull request does
- [ ] Why it does it
- [ ] How it does it
- [ ] Why this approach
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 91959)
Time Spent: 10m
Remaining Estimate: 0h
> Add errorprone to gradle builds
> -------------------------------
>
> Key: BEAM-3697
> URL: https://issues.apache.org/jira/browse/BEAM-3697
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Eugene Kirpichov
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> [http://errorprone.info/] is a good static checker that covers a number of
> bugs not covered by FindBugs or Checkstyle. We use it internally at Google
> and, when run on the Beam codebase, it occasionally uncovers issues missed
> during PR review process.
>
> It has Maven and Gradle plugins:
> [http://errorprone.info/docs/installation]
> [https://github.com/tbroyer/gradle-errorprone-plugin]
>
> It would be good to integrate it into our Maven and Gradle builds.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
