[
https://issues.apache.org/jira/browse/BEAM-3697?focusedWorklogId=92017&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-92017
]
ASF GitHub Bot logged work on BEAM-3697:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Apr/18 01:01
Start Date: 18/Apr/18 01:01
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #5161:
[BEAM-3697] Add errorprone to Gradle build
URL: https://github.com/apache/beam/pull/5161#discussion_r182283356
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/io/fs/ResourceIdTester.java
##########
@@ -108,15 +108,15 @@ private static void
validateFailureResolvingIds(ResourceId baseDirectory) {
try {
ResourceId badFile = baseDirectory.resolve("file/", RESOLVE_FILE);
fail(String.format("Resolving badFile %s should have failed", badFile));
- } catch (Throwable t) {
+ } catch (Exception e) {
Review comment:
Should we narrow the exception to the one which resolve throws?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 92017)
Time Spent: 0.5h (was: 20m)
> Add errorprone to gradle builds
> -------------------------------
>
> Key: BEAM-3697
> URL: https://issues.apache.org/jira/browse/BEAM-3697
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Eugene Kirpichov
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> [http://errorprone.info/] is a good static checker that covers a number of
> bugs not covered by FindBugs or Checkstyle. We use it internally at Google
> and, when run on the Beam codebase, it occasionally uncovers issues missed
> during PR review process.
>
> It has Maven and Gradle plugins:
> [http://errorprone.info/docs/installation]
> [https://github.com/tbroyer/gradle-errorprone-plugin]
>
> It would be good to integrate it into our Maven and Gradle builds.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
