[
https://issues.apache.org/jira/browse/BEAM-4071?focusedWorklogId=91970&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-91970
]
ASF GitHub Bot logged work on BEAM-4071:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/18 23:09
Start Date: 17/Apr/18 23:09
Worklog Time Spent: 10m
Work Description: bsidhom commented on a change in pull request #5150:
[BEAM-4071] Add Portable Runner Job API shim
URL: https://github.com/apache/beam/pull/5150#discussion_r182244056
##########
File path:
runners/reference/java/src/main/java/org/apache/beam/runners/reference/CloseableResource.java
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.reference;
+
+import static com.google.common.base.Preconditions.checkArgument;
+import static com.google.common.base.Preconditions.checkState;
+
+/**
+ * An {@link AutoCloseable} that wraps a resource that needs to be cleaned up
but does not implement
+ * {@link AutoCloseable} itself. Recipients of a {@link CloseableResource} are
in general
+ * responsible for cleanup. Not thread-safe.
+ */
+public class CloseableResource<T> implements AutoCloseable {
+
+ private final T resource;
+ private final Closer<T> closer;
+
+ private boolean isClosed = false;
+
+ private CloseableResource(T resource, Closer<T> closer) {
+ this.resource = resource;
+ this.closer = closer;
+ }
+
+ /** Creates a {@link CloseableResource} with the given resource and closer.
*/
+ public static <T> CloseableResource<T> of(T resource, Closer<T> closer) {
+ checkArgument(resource != null, "Resource must be non-null");
+ checkArgument(closer != null, "%s must be non-null",
Closer.class.getName());
+ return new CloseableResource<>(resource, closer);
+ }
+
+ /** Gets the underlying resource. */
+ public T get() {
+ checkState(!isClosed, "% is closed", CloseableResource.class.getName());
+ return resource;
+ }
+
+ /**
+ * Close the underlying resource. Must only be called once.
+ *
+ * @throws CloseException wrapping any exceptions thrown while closing
+ */
+ @Override
+ public void close() throws CloseException {
+ checkState(!isClosed, "% is closed", CloseableResource.class.getName());
+ try {
+ closer.close(resource);
+ } catch (Exception e) {
+ throw new CloseException(e);
Review comment:
That's interesting because it prevents retries on `close()` where the method
itself attempts to be idempotent. On the other hand, without transactions on
the underlying closer itself, you can't really safely call it multiple times
anyway.
I've changed the logic as per AutoCloseable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 91970)
Time Spent: 5h 50m (was: 5h 40m)
> Portable Runner Job API shim
> ----------------------------
>
> Key: BEAM-4071
> URL: https://issues.apache.org/jira/browse/BEAM-4071
> Project: Beam
> Issue Type: New Feature
> Components: runner-core
> Reporter: Ben Sidhom
> Assignee: Ben Sidhom
> Priority: Minor
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
> There needs to be a way to execute Java-SDK pipelines against a portable job
> server. The job server itself is expected to be started up out-of-band. The
> "PortableRunner" should take an option indicating the Job API endpoint and
> defer other runner configurations to the backend itself.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
