[
https://issues.apache.org/jira/browse/BEAM-4071?focusedWorklogId=91971&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-91971
]
ASF GitHub Bot logged work on BEAM-4071:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/18 23:09
Start Date: 17/Apr/18 23:09
Worklog Time Spent: 10m
Work Description: bsidhom commented on a change in pull request #5150:
[BEAM-4071] Add Portable Runner Job API shim
URL: https://github.com/apache/beam/pull/5150#discussion_r182239755
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineWorkerPoolOptions.java
##########
@@ -189,16 +189,18 @@ public String create(PipelineOptions options) {
String getWorkerMachineType();
void setWorkerMachineType(String value);
+ // TODO: Replace this with PortablePipelineOptions#getFilesToStage.
Review comment:
`getFilesToStage` is referenced in multiple places throughout the Dataflow
runner code. I want to minimize the changes outside of the portable runner
itself here and also want to prevent breaking semantics that the Dataflow
runner expects. For example, getFilesToStage is populated with the runtime
classpath and augmented with other stage files at some point. I'll make a bug
and reference it from `PortablePipelineOptions`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 91971)
Time Spent: 6h (was: 5h 50m)
> Portable Runner Job API shim
> ----------------------------
>
> Key: BEAM-4071
> URL: https://issues.apache.org/jira/browse/BEAM-4071
> Project: Beam
> Issue Type: New Feature
> Components: runner-core
> Reporter: Ben Sidhom
> Assignee: Ben Sidhom
> Priority: Minor
> Time Spent: 6h
> Remaining Estimate: 0h
>
> There needs to be a way to execute Java-SDK pipelines against a portable job
> server. The job server itself is expected to be started up out-of-band. The
> "PortableRunner" should take an option indicating the Job API endpoint and
> defer other runner configurations to the backend itself.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
