[
https://issues.apache.org/jira/browse/BEAM-4135?focusedWorklogId=92801&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-92801
]
ASF GitHub Bot logged work on BEAM-4135:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Apr/18 19:07
Start Date: 19/Apr/18 19:07
Worklog Time Spent: 10m
Work Description: tgroh commented on a change in pull request #5177:
[BEAM-4135] Stop taking the whole result in WatermarkManager
URL: https://github.com/apache/beam/pull/5177#discussion_r182836859
##########
File path:
runners/direct-java/src/main/java/org/apache/beam/runners/direct/WatermarkManager.java
##########
@@ -1542,18 +1539,22 @@ public int compare(CommittedBundle<?> o1,
CommittedBundle<?> o2) {
abstract TimerUpdate getTimerUpdate();
- abstract CommittedResult<ExecutableT> getResult();
+ @Nullable
Review comment:
Documentation in two places is generally poor practice.
I can instead link to the `updateWatermarks` method, and make sure that that
documentation is clean; potentially also noting that the watermarks are not
immediately updated. I've done that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 92801)
Time Spent: 1.5h (was: 1h 20m)
> Remove Use of Java SDK Types in the DirectRunner "engine"
> ---------------------------------------------------------
>
> Key: BEAM-4135
> URL: https://issues.apache.org/jira/browse/BEAM-4135
> Project: Beam
> Issue Type: New Feature
> Components: runner-direct
> Reporter: Thomas Groh
> Assignee: Thomas Groh
> Priority: Major
> Labels: portability
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The "engine" consists of the components which determine where to schedule
> work and route it to the appropriate processors, such as WatermarkManager,
> DirectBundleProcessor, and associated.
>
> These engine components never inspect the actual characteristics of the
> packaged work (e.g. the PCollection is a token, rather than a rich object),
> so they should not require use of a PCollection directly - instead, they can
> be generic.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
