[
https://issues.apache.org/jira/browse/BEAM-4135?focusedWorklogId=95198&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-95198
]
ASF GitHub Bot logged work on BEAM-4135:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Apr/18 19:33
Start Date: 25/Apr/18 19:33
Worklog Time Spent: 10m
Work Description: youngoli commented on a change in pull request #5225:
[BEAM-4135] Fork the DirectRunner Engine
URL: https://github.com/apache/beam/pull/5225#discussion_r184173162
##########
File path:
runners/direct-java/src/main/java/org/apache/beam/runners/direct/portable/DirectTransformExecutor.java
##########
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.direct.portable;
+
+import com.google.common.annotations.VisibleForTesting; import
java.io.Closeable;
Review comment:
Minor nit: Two imports on same line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 95198)
Time Spent: 2h 20m (was: 2h 10m)
> Remove Use of Java SDK Types in the DirectRunner "engine"
> ---------------------------------------------------------
>
> Key: BEAM-4135
> URL: https://issues.apache.org/jira/browse/BEAM-4135
> Project: Beam
> Issue Type: New Feature
> Components: runner-direct
> Reporter: Thomas Groh
> Assignee: Thomas Groh
> Priority: Major
> Labels: portability
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The "engine" consists of the components which determine where to schedule
> work and route it to the appropriate processors, such as WatermarkManager,
> DirectBundleProcessor, and associated.
>
> These engine components never inspect the actual characteristics of the
> packaged work (e.g. the PCollection is a token, rather than a rich object),
> so they should not require use of a PCollection directly - instead, they can
> be generic.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
