[
https://issues.apache.org/jira/browse/BEAM-3303?focusedWorklogId=92913&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-92913
]
ASF GitHub Bot logged work on BEAM-3303:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Apr/18 23:18
Start Date: 19/Apr/18 23:18
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #5179:
[BEAM-3303] Add Go Windowing support
URL: https://github.com/apache/beam/pull/5179#discussion_r182910794
##########
File path: sdks/go/pkg/beam/core/runtime/exec/fn.go
##########
@@ -46,17 +48,22 @@ func Invoke(ctx context.Context, fn *funcx.Fn, opt
*MainInput, extra ...interfac
if index, ok := fn.Context(); ok {
args[index] = ctx
}
+ if index, ok := fn.Window(); ok {
+ if len(ws) != 1 {
+ return nil, fmt.Errorf("DoFns that observe windows must
be invoked with single window: %v", opt.Key.Windows)
Review comment:
<!--new_thread; commit:0c86434e79ad52ef8f6d9957a662379246b3b9ea;
resolved:0-->
When would there be two windows on a PCollection? Simply by applying
WindowInto twice, the second being a finer grain than the first?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 92913)
Time Spent: 1h 50m (was: 1h 40m)
> Go windowing support
> --------------------
>
> Key: BEAM-3303
> URL: https://issues.apache.org/jira/browse/BEAM-3303
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Henning Rohde
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Add support for Window.into and windowing strategies on Node. Implement the
> various windowing strategies Beam has: GlobalWindow, FixedWindows, etc.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
