[
https://issues.apache.org/jira/browse/BEAM-3303?focusedWorklogId=93517&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-93517
]
ASF GitHub Bot logged work on BEAM-3303:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Apr/18 01:15
Start Date: 21/Apr/18 01:15
Worklog Time Spent: 10m
Work Description: herohde commented on a change in pull request #5179:
[BEAM-3303] Add Go Windowing support
URL: https://github.com/apache/beam/pull/5179#discussion_r183195326
##########
File path: sdks/go/pkg/beam/core/runtime/exec/translate.go
##########
@@ -68,15 +69,19 @@ func UnmarshalPlan(desc *fnpb.ProcessBundleDescriptor)
(*Plan, error) {
}
if cid == "" {
- u.Coder, err = b.makeCoderForPCollection(pid)
+ c, wc, err := b.makeCoderForPCollection(pid)
if err != nil {
return nil, err
}
+ u.Coder = coder.NewW(c, wc)
} else {
u.Coder, err = b.coders.Coder(cid) // Expected
to be windowed coder
if err != nil {
return nil, err
}
+ if !coder.IsW(u.Coder) {
+ return nil, fmt.Errorf("unwindowed
coder %v on DataSource %v: %v", cid, id, u.Coder)
Review comment:
Runner bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 93517)
Time Spent: 2h 40m (was: 2.5h)
> Go windowing support
> --------------------
>
> Key: BEAM-3303
> URL: https://issues.apache.org/jira/browse/BEAM-3303
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Henning Rohde
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Add support for Window.into and windowing strategies on Node. Implement the
> various windowing strategies Beam has: GlobalWindow, FixedWindows, etc.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
