[
https://issues.apache.org/jira/browse/BEAM-4097?focusedWorklogId=93406&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-93406
]
ASF GitHub Bot logged work on BEAM-4097:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/18 20:29
Start Date: 20/Apr/18 20:29
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #5191:
[BEAM-4097] Set environment for Python sdk function specs.
URL: https://github.com/apache/beam/pull/5191#discussion_r183156729
##########
File path: sdks/python/apache_beam/pvalue.py
##########
@@ -352,15 +352,17 @@ def __init__(self, access_pattern, window_mapping_fn,
view_fn, coder):
self.view_fn = view_fn
self.coder = coder
- def to_runner_api(self, unused_context):
+ def to_runner_api(self, context):
return beam_runner_api_pb2.SideInput(
access_pattern=beam_runner_api_pb2.FunctionSpec(
urn=self.access_pattern),
view_fn=beam_runner_api_pb2.SdkFunctionSpec(
+ environment_id=context.default_environment_id(),
Review comment:
Should we do context null check here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 93406)
Time Spent: 0.5h (was: 20m)
> Python SDK should set the environment in the job submission protos
> ------------------------------------------------------------------
>
> Key: BEAM-4097
> URL: https://issues.apache.org/jira/browse/BEAM-4097
> Project: Beam
> Issue Type: Task
> Components: sdk-py-core
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
