[ 
https://issues.apache.org/jira/browse/BEAM-4097?focusedWorklogId=93451&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-93451
 ]

ASF GitHub Bot logged work on BEAM-4097:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Apr/18 21:23
            Start Date: 20/Apr/18 21:23
    Worklog Time Spent: 10m 
      Work Description: jkff commented on a change in pull request #5191: 
[BEAM-4097] Set environment for Python sdk function specs.
URL: https://github.com/apache/beam/pull/5191#discussion_r183172787
 
 

 ##########
 File path: 
sdks/python/apache_beam/runners/portability/universal_local_runner.py
 ##########
 @@ -72,6 +74,9 @@ def __init__(
     self._job_service_lock = threading.Lock()
     self._subprocess = None
     self._runner_api_address = runner_api_address
+    self._docker_image = (
+      docker_image
+      or os.environ['USER'] + '-docker.apache.bintray.io/beam/python:latest')
 
 Review comment:
   Additionally, please add a comment about the usage of "USER" - does this 
refer to a container that the user can build themselves? Is it built by default 
as part of some default gradle task?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 93451)
    Time Spent: 50m  (was: 40m)

> Python SDK should set the environment in the job submission protos
> ------------------------------------------------------------------
>
>                 Key: BEAM-4097
>                 URL: https://issues.apache.org/jira/browse/BEAM-4097
>             Project: Beam
>          Issue Type: Task
>          Components: sdk-py-core
>            Reporter: Robert Bradshaw
>            Assignee: Robert Bradshaw
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to