[
https://issues.apache.org/jira/browse/BEAM-4097?focusedWorklogId=94397&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-94397
]
ASF GitHub Bot logged work on BEAM-4097:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Apr/18 00:41
Start Date: 24/Apr/18 00:41
Worklog Time Spent: 10m
Work Description: bsidhom commented on a change in pull request #5191:
[BEAM-4097] Set environment for Python sdk function specs.
URL: https://github.com/apache/beam/pull/5191#discussion_r183577177
##########
File path:
sdks/python/apache_beam/runners/portability/universal_local_runner.py
##########
@@ -83,6 +86,16 @@ def cleanup(self):
time.sleep(0.1)
self._subprocess = None
+ @staticmethod
+ def default_docker_image():
+ if 'USER' in os.environ:
+ # Perhaps also test if this was built?
+ logging.info('Using latest built Python SDK docker image.')
+ return os.environ['USER'] +
'-docker.apache.bintray.io/beam/python:latest'
+ else:
+ logging.warnign('Could not find a Python SDK docker image.')
Review comment:
Apparently it's tested somewhere because the presubmits are failing due to
the `warnign` module not existing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 94397)
Time Spent: 1h 50m (was: 1h 40m)
> Python SDK should set the environment in the job submission protos
> ------------------------------------------------------------------
>
> Key: BEAM-4097
> URL: https://issues.apache.org/jira/browse/BEAM-4097
> Project: Beam
> Issue Type: Task
> Components: sdk-py-core
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)