[
https://issues.apache.org/jira/browse/BEAM-4020?focusedWorklogId=94687&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-94687
]
ASF GitHub Bot logged work on BEAM-4020:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Apr/18 17:04
Start Date: 24/Apr/18 17:04
Worklog Time Spent: 10m
Work Description: iemejia commented on a change in pull request #5212:
[BEAM-4020] Add HBaseIO implementation based on SDF
URL: https://github.com/apache/beam/pull/5212#discussion_r183809639
##########
File path:
sdks/java/io/hbase/src/test/java/org/apache/beam/sdk/io/hbase/HBaseIOTest.java
##########
@@ -180,16 +180,28 @@ public void testReadingFailsTableDoesNotExist() throws
Exception {
public void testReadingEmptyTable() throws Exception {
final String table = tmpTable.getName();
createTable(table);
+
runReadTest(HBaseIO.read().withConfiguration(conf).withTableId(table), new
ArrayList<>());
+ runReadTest(
+ HBaseIO.read().withConfiguration(conf).withTableId(table).useSdf(),
new ArrayList<>());
}
@Test
public void testReading() throws Exception {
final String table = tmpTable.getName();
final int numRows = 1001;
- createTable(table);
- writeData(table, numRows);
-
runReadTestLength(HBaseIO.read().withConfiguration(conf).withTableId(table),
1001);
+ createAndWriteData(table, numRows);
+
+
runReadTestLength(HBaseIO.read().withConfiguration(conf).withTableId(table),
numRows);
+ }
+
+ @Test
+ public void testReadingSDF() throws Exception {
Review comment:
Side note, I just copy/pasted the tests and changed the useSdf value because
I had issues if I called directly
`runReadTestLength(HBaseIO.read().withConfiguration(conf).withTableId(table).useSdf(),
numRows);` after reading for example the normal read.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 94687)
Time Spent: 20m (was: 10m)
> Add an HBaseIO implementation based on SDF
> ------------------------------------------
>
> Key: BEAM-4020
> URL: https://issues.apache.org/jira/browse/BEAM-4020
> Project: Beam
> Issue Type: New Feature
> Components: io-java-hbase
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Since the support from runners is still limited, it is probably wise to
> create a first IO based on the current SDF batch implementation in Java to
> validate/test it with a real data-store. Since HBase partitioning model is
> quite straightforward it is a perfect candidate.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
