[
https://issues.apache.org/jira/browse/BEAM-4020?focusedWorklogId=94773&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-94773
]
ASF GitHub Bot logged work on BEAM-4020:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Apr/18 19:48
Start Date: 24/Apr/18 19:48
Worklog Time Spent: 10m
Work Description: iemejia commented on a change in pull request #5212:
[BEAM-4020] Add HBaseIO implementation based on SDF
URL: https://github.com/apache/beam/pull/5212#discussion_r183857567
##########
File path:
sdks/java/io/hbase/src/main/java/org/apache/beam/sdk/io/hbase/HBaseIO.java
##########
@@ -198,6 +201,13 @@ public Read withKeyRange(byte[] startRow, byte[] stopRow)
{
return withKeyRange(keyRange);
}
+ @VisibleForTesting
+ Read useSdf() {
+ Read read = new Read(serializableConfiguration, tableId,
serializableScan);
+ read.useSDF = true;
Review comment:
For the moment I think we are ok as it is, the arguments of HBaseIO are
pretty small to add all the overhead of AutoValue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 94773)
Time Spent: 1h 20m (was: 1h 10m)
> Add an HBaseIO implementation based on SDF
> ------------------------------------------
>
> Key: BEAM-4020
> URL: https://issues.apache.org/jira/browse/BEAM-4020
> Project: Beam
> Issue Type: New Feature
> Components: io-java-hbase
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Since the support from runners is still limited, it is probably wise to
> create a first IO based on the current SDF batch implementation in Java to
> validate/test it with a real data-store. Since HBase partitioning model is
> quite straightforward it is a perfect candidate.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
