[
https://issues.apache.org/jira/browse/BEAM-3327?focusedWorklogId=95785&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-95785
]
ASF GitHub Bot logged work on BEAM-3327:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Apr/18 00:00
Start Date: 27/Apr/18 00:00
Worklog Time Spent: 10m
Work Description: jkff commented on a change in pull request #5152:
[BEAM-3327] Harness Manager Interfaces
URL: https://github.com/apache/beam/pull/5152#discussion_r184561494
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/RemoteBundle.java
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.beam.runners.fnexecution.control;
+
+import org.apache.beam.sdk.fn.data.FnDataReceiver;
+import org.apache.beam.sdk.util.WindowedValue;
+
+/**
+ * A bundle capable of handling input data elements for a
+ * {@link
org.apache.beam.model.fnexecution.v1.BeamFnApi.ProcessBundleDescriptor bundle
descriptor}
+ * by forwarding them to a remote environment for processing.
+ *
+ * <p>When a RemoteBundle is closed, it will block until bundle processing is
finished on remote
+ * resources, and throw an exception if bundle processing has failed.
+ */
+public interface RemoteBundle<InputT> extends AutoCloseable {
+ /**
+ * Get an id used to represent this bundle.
+ */
+ String getBundleId();
+
+ /**
+ * Get a {@link FnDataReceiver receiver} which consumes input elements,
forwarding them to the
+ * remote environment.
+ */
+ FnDataReceiver<WindowedValue<InputT>> getInputReceiver();
Review comment:
Maybe can RemoteBundle _implement_ FnDataReceiver instead of returning it?
Seems it would be a bit more concise both for implementation and for users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 95785)
> Add abstractions to manage Environment Instance lifecycles.
> -----------------------------------------------------------
>
> Key: BEAM-3327
> URL: https://issues.apache.org/jira/browse/BEAM-3327
> Project: Beam
> Issue Type: New Feature
> Components: runner-core
> Reporter: Thomas Groh
> Assignee: Ben Sidhom
> Priority: Major
> Labels: portability
> Time Spent: 24h 10m
> Remaining Estimate: 0h
>
> This permits remote stage execution for arbitrary environments
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
