[ 
https://issues.apache.org/jira/browse/BEAM-3327?focusedWorklogId=95788&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-95788
 ]

ASF GitHub Bot logged work on BEAM-3327:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Apr/18 00:00
            Start Date: 27/Apr/18 00:00
    Worklog Time Spent: 10m 
      Work Description: jkff commented on a change in pull request #5152: 
[BEAM-3327] Harness Manager Interfaces
URL: https://github.com/apache/beam/pull/5152#discussion_r184562601
 
 

 ##########
 File path: 
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/StaticBundleFactory.java
 ##########
 @@ -0,0 +1,14 @@
+package org.apache.beam.runners.fnexecution.control;
+
+import org.apache.beam.runners.fnexecution.artifact.ArtifactSource;
+import org.apache.beam.runners.fnexecution.provisioning.JobInfo;
+
+/**
+ * A factory that can create {@link JobBundleFactory JobBundleFactories} from 
job-scoped resources
+ * provided by an operator.
+ *
+ * <p>This should be a global or singleton resource that caches 
JobBundleFactories between calls.
 
 Review comment:
   Yeah I think this doesn't need an interface. I'm also not sure whether its 
implementation per se should be runner-specific, or whether one should pass 
runner-specific hooks into a general-purpose implementation. For this PR, 
probably fine to either convert this to a class with a static method, or omit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 95788)
    Time Spent: 24.5h  (was: 24h 20m)

> Add abstractions to manage Environment Instance lifecycles.
> -----------------------------------------------------------
>
>                 Key: BEAM-3327
>                 URL: https://issues.apache.org/jira/browse/BEAM-3327
>             Project: Beam
>          Issue Type: New Feature
>          Components: runner-core
>            Reporter: Thomas Groh
>            Assignee: Ben Sidhom
>            Priority: Major
>              Labels: portability
>          Time Spent: 24.5h
>  Remaining Estimate: 0h
>
> This permits remote stage execution for arbitrary environments



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to