[
https://issues.apache.org/jira/browse/BEAM-4073?focusedWorklogId=98013&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-98013
]
ASF GitHub Bot logged work on BEAM-4073:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/May/18 19:14
Start Date: 03/May/18 19:14
Worklog Time Spent: 10m
Work Description: huygaa11 commented on a change in pull request #5228:
[BEAM-4073] Expand ExecutableGraph, and add a Portable Representation
URL: https://github.com/apache/beam/pull/5228#discussion_r185877595
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/graph/QueryablePipeline.java
##########
@@ -217,6 +226,19 @@ public PTransformNode getProducer(PCollectionNode
pcollection) {
.collect(Collectors.toSet());
}
+ /**
+ * Gets each {@link PCollectionNode} that the provided {@link
PTransformNode} consumes on a
+ * per-element basis.
+ */
+ public Set<PCollectionNode> getPerElementInputs(PTransformNode ptransform) {
Review comment:
Unless there is a method name length concern, naming this method
getPerElementInputPCollections would make it clear and consistent with the
getOutputPCollections method underneath.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 98013)
Time Spent: 50m (was: 40m)
> The DirectRunner should interact with a Pipeline via an abstraction of the
> Graph rather than SDK types
> ------------------------------------------------------------------------------------------------------
>
> Key: BEAM-4073
> URL: https://issues.apache.org/jira/browse/BEAM-4073
> Project: Beam
> Issue Type: Bug
> Components: runner-direct
> Reporter: Thomas Groh
> Assignee: Thomas Groh
> Priority: Major
> Labels: portability
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
